major update

Uninstall-AteraAgent.ps1

@@ -1,9 +1,11 @@
 
 Function Get-UninstallCodes ([string]$DisplayName) {
-    Get-ChildItem -Path 'HKLM:SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall' | ForEach-Object {
-        If ( $(Get-ItemProperty -Path $_.PSPath -Name 'DisplayName' -ErrorAction SilentlyContinue) -and ($(Get-ItemPropertyValue -Path $_.PSPath -Name 'DisplayName' -ErrorAction SilentlyContinue) -eq $DisplayName) ) {
-            $str = (Get-ItemPropertyValue -Path $_.PSPath -Name 'UninstallString')
-            $UninstallCodes += $str.Substring(($str.Length - 37),36)
+    'HKLM:SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall', 'HKLM:SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall' | ForEach-Object {
+        Get-ChildItem -Path $_ -ErrorAction SilentlyContinue | ForEach-Object {
+            If ( $(Get-ItemProperty -Path $_.PSPath -Name 'DisplayName' -ErrorAction SilentlyContinue) -and ($(Get-ItemPropertyValue -Path $_.PSPath -Name 'DisplayName' -ErrorAction SilentlyContinue) -eq $DisplayName) ) {
+                $str = (Get-ItemPropertyValue -Path $_.PSPath -Name 'UninstallString')
+                $UninstallCodes.Add($str.Substring(($str.Length - 37),36)) | Out-Null
+            }
         }
     }
 }
@@ -11,7 +13,7 @@ Function Get-UninstallCodes ([string]$DisplayName) {
 Function Get-ProductKeys ([string]$ProductName) {
     Get-ChildItem -Path 'HKCR:Installer\Products' | ForEach-Object {
         If ( $(Get-ItemProperty -Path $_.PSPath -Name 'ProductName' -ErrorAction SilentlyContinue) -and ($(Get-ItemPropertyValue -Path $_.PSPath -Name 'ProductName' -ErrorAction SilentlyContinue) -eq $ProductName) ) {
-            $ProductKeys += $_.PSPath.Substring(($_.PSPath.Length - 32))
+            $ProductKeys.Add($_.PSPath.Substring(($_.PSPath.Length - 32))) | Out-Null
         }
     }
 }
@@ -19,31 +21,35 @@ Function Get-ProductKeys ([string]$ProductName) {
 Function Get-ServiceStatus ([string]$Name) { (Get-Service -Name $Name -ErrorAction SilentlyContinue).Status }
 
 Function Stop-RunningService ([string]$Name) {
-    If ( $(Get-ServiceStatus -Name $Name) -eq "Running" ) { Write-Output "Stopping ${Name} service" ; Stop-Service -Name $Name -Force }
+    If ( $(Get-ServiceStatus -Name $Name) -eq "Running" ) { Write-Output "Stopping : ${Name} service" ; Stop-Service -Name $Name -Force }
 }
 
 Function Remove-StoppedService ([string]$Name) {
-    If ( $(Get-ServiceStatus -Name $Name) -eq "Stopped" ) {
-        Write-Output "Deleting ${Name} service"
-        Start-Process "sc.exe" -ArgumentList "delete ${Name}" -Wait
-    }
+    $s = (Get-ServiceStatus -Name $Name)
+    If ( $s ) {
+        If ( $s -eq "Stopped" ) {
+            Write-Output "Deleting : ${Name} service"
+            Start-Process "sc.exe" -ArgumentList "delete ${Name}" -Wait
+        }
+    } Else { Write-Output "Not Found: ${Name} service" }
 }
 
-Function Kill-Process ([string]$Name) {
+Function Stop-RunningProcess ([string]$Name) {
     $p = (Get-Process -Name $_ -ErrorAction SilentlyContinue)
-    If ( $p ) { Write-Output "Killing ${Name} process" ; $p | Stop-Process -Force }
+    If ( $p ) { Write-Output "Stopping : ${Name}.exe" ; $p | Stop-Process -Force }
+    Else { Write-Output "Not Found: ${Name}.exe is not running"}
 }
 
 Function Remove-Path ([string]$Path) {
     If ( Test-Path $Path ) {
-        Write-Output "Deleting ${Path}"
-        Remove-Item -Path $Path -Force
-    } Else { Write-Output "ERROR: Path not found: ${Path}" }
+        Write-Output "Deleting : ${Path}"
+        Remove-Item $Path -Recurse -Force
+    } Else { Write-Output "Not Found: ${Path}" }
 }
 
 Function Get-AllExeFiles ([string]$Path) {
     If ( Test-Path $Path ) {
-        Get-ChildItem -Path $Path -Filter *.exe -Recurse | ForEach-Object { $ExeFiles =+ $_.BaseName }
+        Get-ChildItem -Path $Path -Filter *.exe -Recurse | ForEach-Object { $ExeFiles.Add($_.BaseName) | Out-Null }
     }
 }
 
@@ -55,11 +61,11 @@ New-PSDrive -Name HKCR -PSProvider Registry -Root HKEY_CLASSES_ROOT | Out-Null
 #######
 
 # Get MSI package codes from the uninstall key
-$UninstallCodes = @()
+$UninstallCodes = New-Object System.Collections.ArrayList
 'AteraAgent', 'Splashtop for RMM', 'Splashtop Streamer' | ForEach-Object { Get-UninstallCodes -DisplayName $_ }
 
 # Get product keys from the list of installed products
-$ProductKeys = @()
+$ProductKeys = New-Object System.Collections.ArrayList
 'AteraAgent', 'Splashtop for RMM', 'Splashtop Streamer' | ForEach-Object { Get-ProductKeys -ProductName $_ }
 
 # Define all the directories we'll need to cleanup at the end of this script
@@ -73,8 +79,8 @@ $Directories = @(
 )
 
 # Get all possible relevant exe files so we can make sure they're closed later on
-$ExeFiles = @()
-$Directories | ForEach-Object { Get-AllExeFiles -Path $_ }
+$ExeFiles = New-Object System.Collections.ArrayList
+"${Env:ProgramFiles}\ATERA Networks" | ForEach-Object { Get-AllExeFiles -Path $_ }
 
 # Define a list of services we need to stop and delete (if necessary)
 $ServiceList = @(
@@ -95,21 +101,18 @@ $RegistryKeys = @(
 #######
 
 # Uninstall each MSI package code in $UninstallCodes
-$UninstallCodes | ForEach-Object { Write-Output "Uninstalling product code: ${_}" ; Start-Process "msiexec.exe" -ArgumentList "/X{${_}}" -Wait }
+$UninstallCodes | ForEach-Object { Write-Output "Uninstall: ${_}" ; Start-Process "msiexec.exe" -ArgumentList "/X{${_}} /qn" -Wait }
 
 # Stop services if they're still running
 $ServiceList | ForEach-Object { Stop-RunningService -Name $_ }
 
-# Kill all relevant processes that may still be running
-$ExeFiles += 'reg'
-$ExeFiles | ForEach-Object { Kill-Process $_ }
+# Terminate all relevant processes that may still be running
+$ExeFiles.Add('reg')  | Out-Null
+$ExeFiles | ForEach-Object { Stop-RunningProcess $_ }
 
 # Delete services if they're still present
 $ServiceList | ForEach-Object { Remove-StoppedService -Name $_ }
 
-# This seems unnecessary, but it's included in Atera's official uninstall script so I included it here but left it commented out
-#Start-Sleep -Seconds 4
-
 # Delete products from MSI installer registry
 $ProductKeys | ForEach-Object { Remove-Path -Path "HKCR:Installer\Products\${_}" }
 
@@ -120,6 +123,7 @@ Remove-PSDrive -Name HKCR
 $RegistryKeys | ForEach-Object { Remove-Path -Path $_ }
 
 # Delete remaining directories
+#Write-Host "Waiting for file locks to be freed" ; Start-Sleep -Seconds 4
 $Directories | ForEach-Object { Remove-Path -Path $_ }
 
 # Atera's original script also deleted the following directories and registry keys